Fix: avoid further dispatch when ThreadContext population fails #121665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>bug
>non-issue
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
approved these changes
Feb 4, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM
Slightly odd tests, kind of unrelated to the bug in question, tho it's not easy to see how else to test for this bug.
Contributor
Author
I agree they are kind of unrelated: the case (in)sensitiveness tests came first, just to "prove" (for an unrelated issue) that ES was behaving correctly. They just highlighted the error, as they failed but not where I expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding some tests to assert that ES handling of multiple headers is in line with the specs (headers are treated in a case-insensitive way - see #116139), we discovered a problem introduced with #95040.
If the header validation fails while we populate the ThreadContext, an error answer is sent, but we also proceed with the normal dispatch. This causes an error downstream: as soon as we try to read the request body, an assertion is hit, as the request has already been closed and marked as completed.
This PR fixes the issue by making the 2 paths mutually exclusive.